git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [2/2] calcite git commit: [CALCITE-2347] running ElasticSearch in embedded mode for unit tests of ES adapter (Andrei Sereda)


OK. I'm working on it.

On Mon, Jun 25, 2018 at 2:18 PM Julian Hyde <jhyde@xxxxxxxxxx> wrote:

> > On Jun 25, 2018, at 11:11 AM, Andrei Sereda <andrei@xxxxxxxxx> wrote:
> >
> > Would you consider merging this partial javadoc fix (PR 741
> > <https://github.com/apache/calcite/pull/741>) as precursor for
> CALCITE-2376 ?
> > Former PR has also fixes javadoc issues for mongo adapter.
>
> No.
>
> I have 5 commits that I would like to merge but cannot because my builds
> fail. We need to fix the big problem before we do anything else.
>
> > I'm working on CALCITE-2376 which unifies ES2 and ES5 adapters. I'll make
> > sure it is passing both javadoc / site tasks in maven.
>
> Sounds very cool, but I’m not an ES expert. I think you should get buy-in
> from other people who have worked on the ES adapter(s) before you go too
> far down that path.
>
> Also, it is a big solution to a small (but urgent) problem. Let’s fix that
> problem with a quick, small fix.
>
> > On a separate note, do you think it makes sense to add javadoc generation
> > to travis build ?
>
> I would love to, but IIRC, travis times out if you add javadoc generation.
>
> Julian
>
>