git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ElasticSearch use of rest client (instead of TransportClient)


Some questions regarding this change:

1) Should one remove ES2 and ES5 adapters (maven modules) in favor of
single one: just ES ? This will be backwards incompatible change. Or keep
them as is and create a new module ? There is also quite a bit of ES
related code in calcite-core.

2) Since I need to create / parse JSON formats, ES adapter would have to
depend on some JSON library (most likely existing Jackson). Is that
acceptable ?



On Fri, May 18, 2018 at 4:29 PM Andrei Sereda <andrei@xxxxxxxxx> wrote:

> I believe this shouldn't be an issue with http client (contrary to native
> transport)
>
> On Fri, May 18, 2018, 16:16 Christian Beikov <christian.beikov@xxxxxxxxx>
> wrote:
>
>> That's mainly because the Java drivers changed in a way that made
>> impossible to use the same adapter. I might be wrong, but I think the
>> ES5 adapter doesn't work with an ES2 server instance just like the ES2
>> adapter doesn't work with an ES5+ server instance.
>>
>> If all of this could just go away, that would be great :)
>>
>>
>> Mit freundlichen Grüßen,
>> ------------------------------------------------------------------------
>> *Christian Beikov*
>> Am 18.05.2018 um 21:19 schrieb Andrei Sereda:
>> > Yes it should be, since it is just an http client (apache http).
>> > ElasticSearch Rest API (query API) didn't change much
>> > <
>> https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking-changes-5.0.html
>> >
>> > .
>> >
>> > Next question would be : why there is a need in two separate modules
>> > elasticsearch2 and elasticsearch5
>> >
>> > On Fri, May 18, 2018 at 3:11 PM, Christian Beikov <
>> > christian.beikov@xxxxxxxxx> wrote:
>> >
>> >> Hey Andrei,
>> >>
>> >> that would be awesome! Do you know by any chance if the low level
>> client
>> >> is also compatible with older ES versions?
>> >>
>> >>
>> >> Mit freundlichen Grüßen,
>> >>
>> ------------------------------------------------------------------------
>> >> *Christian Beikov*
>> >> Am 18.05.2018 um 20:45 schrieb Andrei Sereda:
>> >>
>> >>> Hello,
>> >>>
>> >>> ES TransportClient is deprecated in 7.0 (to be removed
>> >>> <https://www.elastic.co/guide/en/elasticsearch/client/java-a
>> >>> pi/master/transport-client.html>
>> >>> in 8.0) in favor of http rest client(s). Would you consider a
>> contribution
>> >>> switching to Rest Low-Level Client
>> >>> <https://www.elastic.co/guide/en/elasticsearch/client/java-r
>> >>> est/current/java-rest-low.html>(which
>> >>> has much fewer dependencies) ?
>> >>>
>> >>>
>> >>> Thanks,
>> >>> Andrei.
>> >>>
>> >>>
>>
>>