git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Release calcite-avatica-1.12.0 (release candidate 0)


I did have my PGP fingerprint updated at id.apache.org. I think there might be some issues with pgp.mit.edu. I tried importing your key and PGP also hangs for a very long time. In the meantime, I uploaded my public key to https://sks-keyservers.net/ and https://keyserver.pgp.com

I think adding build instructions in the README is a good idea. However, since we're in release mode, can we punt that to the next release?

Re the missing names in the release history, my apologies for the oversight. I will add them in once after the release.

Francis

On 22/06/2018 10:41 AM, Julian Hyde wrote:
+1

Downloaded, checked digests, built and ran tests (“mvn install”) on macOS under JDK 9, ran apache-rat.

Big thanks to Francis for being release manager, and to the many — more than usual! — folks who contributed to this release.

Comments:
I was not able to obtain Francis’ key from a public key-server (i.e. "gpg --keyserver pgpkeys.mit.edu --recv-key 0xBBE44E923A970AB7” failed). Francis should fix that (I think the solution is to add to your id.apache.org <http://id.apache.org/> entry). I worked around using “curl … | gpg —import”.
In my opinion, a source release should have instructions how to build in either README or README.md. This does not.
In history, contributions by non-committers should be followed by their name in parentheses. This is not the case for contributions by Karan Mehta (2285), Alex Araujo (2284). This does not need to be fixed before release, but please fix ASAP afterwards.
Julian


On Jun 21, 2018, at 12:38 PM, Kevin Risden <krisden@xxxxxxxxxx> wrote:

+1

checked gpg, sha256, compiled and ran tests using JDK 8_172, 9.0.4, 10.0.1,
and 11-ea build 18.

I tried to build and run tests against Calcite with rc0. There will be some
changes required to Calcite due to CALCITE-2219. Looks like Calcite had
been assuming that "closed" connections could just be reused without doing
anything to them. It breaks some assumptions about pooling tests and others.

Some quick tests with Apache Solr and Avatica 0.12.0 rc0 look like there
are no problems for that integration.

Kevin Risden

On Thu, Jun 21, 2018 at 7:33 AM, Michael Mior <mmior@xxxxxxxxxxxx> wrote:

+1 (binding) checked hashes and compiled and ran tests

Thanks Francis!

--
Michael Mior
mmior@xxxxxxxxxxxx


Le jeu. 21 juin 2018 à 08:21, Francis Chuang <francischuang@xxxxxxxxxx> a
écrit :

Hi all,

I have created a build for Apache Calcite Avatica 1.12.0, release
candidate 0.

Thanks to everyone who have contributed to this release.
You can read the release notes here:

https://github.com/apache/calcite-avatica/blob/branch-
avatica-1.12/site/_docs/history.md
The commit to be voted upon:

http://git-wip-us.apache.org/repos/asf/calcite-avatica/commit/
019a4ec4ac2c952f842bca7ecfcfc86761b0f9c6
Its hash is 019a4ec4ac2c952f842bca7ecfcfc86761b0f9c6

The artifacts to be voted on are located here:

https://dist.apache.org/repos/dist/dev/calcite/apache-
calcite-avatica-1.12.0-rc0
The hashes of the artifact are as follows:
src.tar.gz.sha256
6408dacb66d28a2021dde761cfe153d96656aa1ca65adb7a1e8765dbe7dae7f8

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1043

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/francischuang.asc

Please vote on releasing this package as Apache Calcite Avatica 1.12.0.

The vote is open for the next 72 hours and passes if a majority of
at least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite Avatica 1.11.0
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...


Here is my vote:

+1 (binding)

Francis