git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CalcitePrepare inconsistantly applies parser config


You are correct; we should be more consistent.

I think there’s a JIRA case that we should use the same mechanism for preparing queries inside the JDBC driver (i.e. driven by CalcitePrepare) as outside a JDBC driver (i.e. using Frameworks). But that would be a lot of work. If you can find some small ways to make them more consistent (e.g. using the same config) that would be helpful.

Julian


> On May 14, 2018, at 11:41 AM, Andrew Pilloud <apilloud@xxxxxxxxxx.INVALID> wrote:
> 
> I've noticed that the CalcitePrepare interface creates a parser in both the
> parse and prepare paths, but only the prepare path applies the custom
> parser config from the context. Is this intentional? Shouldn't both paths
> use the config from the context?
> 
> Andrew