git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Calcite - JDK 8 and Use of Guava


There is a discussion in SOLR-11763 about Guava and limiting its use by
replacing with native JDK 8 alternatives. Since Calcite 0.16.0 is now on
minimum JDK 8 this looks to be viable.  CALCITE-2259 identifies a few other
JDK 8 nice to haves.

One example looks to be:
* Preconditions.checkNotNull(obj); // Guava
* Objects.requireNonNull(obj); // JDK 8

Are there any concerns with looking into this? Are there any known features
of Guava that are necessary? I know some adapters might require Guava.

I am just starting to look at this and figured I'd ask before diving in
head first. I would start with core and then work out to other modules.

[1] https://issues.apache.org/jira/browse/SOLR-11763
[2] https://issues.apache.org/jira/browse/CALCITE-2259

Kevin Risden


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-calcite-development/msg03326.html on line 87
Call Stack
#TimeMemoryFunctionLocation
10.0007363648{main}( ).../msg03326.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-calcite-development/msg03326.html on line 87
Call Stack
#TimeMemoryFunctionLocation
10.0007363648{main}( ).../msg03326.html:0