git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jira] [Created] (CALCITE-2279) Druid adapter duplicates binary expression


Kevin Risden created CALCITE-2279:
-------------------------------------

             Summary: Druid adapter duplicates binary expression
                 Key: CALCITE-2279
                 URL: https://issues.apache.org/jira/browse/CALCITE-2279
             Project: Calcite
          Issue Type: Bug
          Components: druid
            Reporter: Kevin Risden
            Assignee: Julian Hyde
             Fix For: 1.17.0


I was looking into Error Prone [1] checking for Calcite and it found what looks like a bug in Druid Adapter. The output is as follows
 
{quote}DruidJsonFilter.java:[324,9] [IdentityBinaryExpression] A binary expression where both operands are the same is usually incorrect; the value of this expression is equivalent to `lhs.getType().getFamily() == SqlTypeFamily.NUMERIC`.
[ERROR]     (see [http://errorprone.info/bugpattern/IdentityBinaryExpression]){quote}
 
The DruidJsonFilter [2] has left and right hand the exact same.
 
[1] [http://errorprone.info/]
[2] [https://github.com/apache/calcite/blob/master/druid/src/main/java/org/apache/calcite/adapter/druid/DruidJsonFilter.java#L323]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-calcite-development/msg03304.html on line 98
Call Stack
#TimeMemoryFunctionLocation
10.0007358472{main}( ).../msg03304.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-calcite-development/msg03304.html on line 98
Call Stack
#TimeMemoryFunctionLocation
10.0007358472{main}( ).../msg03304.html:0