git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server issue #1014: [WIP] Subtype setting config val: use as key’...


Github user ahgittin commented on the issue:

    https://github.com/apache/brooklyn-server/pull/1014
  
    I like this idea but the test failures highlight an edge cases that need some thinking.
    
    `BasicConfigKeyOverwriting` has different resolution semantics to some of the structured key types (eg SetConfigKey) so by changing the key to have a different default value we inadvertently change how it resolves, leading in some cases to List being returned for a SetConfigKey
    
    This can possibly be resolved by making the key-overwrite method aware of the different ConfigKey subtypes.  Will be interesting to see whether that improves the test failure situation.
    
    Re the problem you mention, default values being different now for keys that have a value set in YAML, I don't think that's a problem.  It has some notable implications, e.g. if a config value is subsequently cleared the initial YAML-set value will be returned on read, rather than the original key definition default -- but I think this is okay.


---