git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks


Github user ahgittin commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/96#discussion_r230391995
  
    --- Diff: ui-modules/blueprint-composer/app/components/spec-editor/spec-editor.template.html ---
    @@ -341,7 +341,9 @@ <h4>No matching configuration</h4>
     </br-collapsible>
     
     <!-- ENTITY LOCATION -->
    -<br-collapsible ng-if="[FAMILIES.ENTITY, FAMILIES.SPEC].indexOf(model.family) > -1" state="state.location.open">
    +<ng-include src="'SpecEditorLocationSection.html'"></ng-include>
    --- End diff --
    
    agree w making these unique.  i think it should definitely have the project name in it to make this happen.
    
    don't think there's much value in component type.  `project_id/component_id/template_id` would get my vote.


---