git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #96: Relevance and other composer tweaks


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/96#discussion_r230347692
  
    --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.template.html ---
    @@ -145,19 +153,29 @@ <h3>{{freeFormTile | entityName}}</h3>
     <!-- QUICK INFO TEMPLATE :: START-->
     <script type="text/ng-template" id="QuickInfoTemplate.html">
         <div class="palette-item-quick-info">
    -        <div class="deprecated-marker" ng-if="item.deprecated">DEPRECATED</div>
    +        <div class="quick-info-title">{{ popover | entityName }}
    +            <br-svg type="close" class="pull-right closer" ng-click="closePopover()"></br-svg>
    +        </div>
    +        <div class="deprecated-marker" ng-if="popover.deprecated">DEPRECATED</div>
             <div class="quick-info-metadata">
    -            <p><i class="mini-icon fa fa-fw fa-bookmark"></i> <samp class="type-symbolic-name">{{item.symbolicName}}</samp></p>
    -            <p ng-if="item.version"><i class="mini-icon fa fa-fw fa-code-fork"></i> {{item.version}}</p>
    +            <p><i class="mini-icon fa fa-fw fa-bookmark"></i> <samp class="type-symbolic-name">{{popover.symbolicName}}</samp></p>
    +            <p ng-if="popover.version"><i class="mini-icon fa fa-fw fa-code-fork"></i> {{popover.version}}</p>
             </div>
    -        <p class="quick-info-description" ng-if="item.description">{{item.description}}</p>
    +        <p class="quick-info-description" ng-if="popover.description">{{popover.description}}</p>
             <div class="quick-info-metadata bundle">
    -            <p ng-if="lastUsedText(item)"><i class="mini-icon fa fa-clock-o"></i> {{ lastUsedText(item) }}</p>
    -            <p ng-if="item.displayTags && item.displayTags.length"><i class="mini-icon fa fa-fw fa-tags"></i> 
    -                <span ng-repeat-start="tag in item.displayTags" class="label label-primary palette-item-tag">{{ tag }}</span>
    +            <p ng-if="lastUsedText(popover)"><i class="mini-icon fa fa-clock-o"></i> {{ lastUsedText(popover) }}
    +              <br-svg type="close" class="closer" ng-click="popover.lastUsed = 0"></br-svg>
    +            </p>
    +            <p ng-if="popover.displayTags && popover.displayTags.length"><i class="mini-icon fa fa-fw fa-tags"></i> 
    +                <span ng-repeat-start="tag in popover.displayTags" class="label label-primary palette-item-tag">{{ tag }}</span>
                     <span ng-repeat-end> </span> </p>
    -            <p><i class="mini-icon fa fa-fw fa-file-zip-o"></i> {{item.containingBundle}}</p>
    -            <p ng-if="item.relevance"><i class="mini-icon fa fa-sort-numeric-asc"></i> Relevance score: {{ roundTwoDecimals(item.relevance) }}</p>
    +            <p><i class="mini-icon fa fa-fw fa-file-zip-o"></i> {{popover.containingBundle}}</p>
    +            <p ng-if="popover.relevance"><i class="mini-icon fa fa-sort-numeric-asc"></i> Relevance score: {{ roundTwoDecimals(popover.relevance) }}</p>
    --- End diff --
    
    I don't think seeing the relevance number has any value for the user. In fact, we don't explain nor display what is the scale and order of this. I think we should not display this


---