git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-ui pull request #94: Composer recent and filters


Github user tbouron commented on a diff in the pull request:

    https://github.com/apache/brooklyn-ui/pull/94#discussion_r228903921
  
    --- Diff: ui-modules/blueprint-composer/app/components/catalog-selector/catalog-selector.directive.js ---
    @@ -30,15 +47,43 @@ export function catalogSelectorDirective() {
             scope: {
                 family: '<',
                 onSelect: '&',
    -            itemsPerPage: '<',
    +            rowsPerPage: '<',  // if unset then fill
    --- End diff --
    
    If this parameter is option, it should have a `?` at the end, like the ones below


---