git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server pull request #968: does a yaml parse and compares the hash o...


GitHub user ahgittin opened a pull request:

    https://github.com/apache/brooklyn-server/pull/968

    does a yaml parse and compares the hash of the result when checking plan equivalence

    means that the same plan entered twice but with different comments, spacing, quotations etc,
    will not result in an error.  it only treats a plan as non-equivalent if their yaml is different
    after a deserialize-then-serialize cycle.  previously a catalog push for an already-present
    non-snapshot plan would fail unless the plan was identical up to a trim.  now it only fails if
    the objects are different.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ahgittin/brooklyn-server better-plan-equivalence

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-server/pull/968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #968
    
----
commit a5d61ed1611fbc132185d0a72ffe82036fd86fd4
Author: Alex Heneveld <alex.heneveld@...>
Date:   2018-06-01T23:29:02Z

    does a yaml parse and compares the hash of the result when checking plan equivalence
    
    means that the same plan entered twice but with different comments, spacing, quotations etc,
    will not result in an error.  it only treats a plan as non-equivalent if their yaml is different
    after a deserialize-then-serialize cycle.  previously a catalog push for an already-present
    non-snapshot plan would fail unless the plan was identical up to a trim.  now it only fails if
    the objects are different.

----


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-brooklyn-development/msg07758.html on line 111
Call Stack
#TimeMemoryFunctionLocation
10.0008364728{main}( ).../msg07758.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-brooklyn-development/msg07758.html on line 111
Call Stack
#TimeMemoryFunctionLocation
10.0008364728{main}( ).../msg07758.html:0