[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-dist pull request #121: [BROOKLYN-579] Add DNS TTL configuration vi...

Github user geomacy commented on a diff in the pull request:
    --- Diff: karaf/apache-brooklyn/src/main/resources/bin/setenv ---
    @@ -85,6 +89,9 @@ export EXTRA_JAVA_OPTS="-Dbrooklyn.location.localhost.address= ${EXTRA_
     # Increase garbage collection, see
     export EXTRA_JAVA_OPTS="-XX:SoftRefLRUPolicyMSPerMB=1 ${EXTRA_JAVA_OPTS}"
    +# Set the DNS TTL for the JVM
    --- End diff --
    It would be nicer not to use the `sun` private system property but I take your point about the other value being a security property.  I had a look to see if Karaf would let us specify this somehow but I don't see a way to do that.  (You can configure security providers but there doesn't seem to be an equivalent for security properties.)
    At the least though I would add some comment here explaining the use of `` - even just copy the text from the description of this PR.


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-brooklyn-development/msg07739.html on line 88
Call Stack
10.0008364728{main}( ).../msg07739.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-brooklyn-development/msg07739.html on line 88
Call Stack
10.0008364728{main}( ).../msg07739.html:0