git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] brooklyn-server pull request #964: Persistence efficiency do less: don't per...


Github user geomacy commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/964#discussion_r191382020
  
    --- Diff: core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java ---
    @@ -222,6 +223,7 @@ public PeriodicDeltaChangeListener(
             this.persistPoliciesEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_POLICY_PERSISTENCE_PROPERTY);
             this.persistEnrichersEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_ENRICHER_PERSISTENCE_PROPERTY);
             this.persistFeedsEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_FEED_PERSISTENCE_PROPERTY);
    +        this.persistReferencedObjectsEnabled = BrooklynFeatureEnablement.isEnabled(BrooklynFeatureEnablement.FEATURE_REFERENCED_OBJECTS_PERSISTENCE_PROPERTY);
    --- End diff --
    
    might be worth naming this `rePersistReferencedObjectsEnabled` as its behaviour is different from the flags above, isn't it - they disable persistence of feeds etc. entirely, whereas this just disables the periodic re-persistence.  See comment on 542 below.


---



( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-brooklyn-development/msg07730.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0007364728{main}( ).../msg07730.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-brooklyn-development/msg07730.html on line 85
Call Stack
#TimeMemoryFunctionLocation
10.0007364728{main}( ).../msg07730.html:0