git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VOTE] Apache BookKeeper Release 4.7.0, release candidate #0


2018-04-11 17:46 GMT+02:00 Enrico Olivelli <eolivelli@xxxxxxxxx>:

> I must add that I have tests on a downstream project (HerdDB) which are
> consistently failing just by upgrading from 4.6.1 to 4.7.0rc0
>
> Tests are about Bookie failures and Fencing.
>
> I am trying to understand the root cause, but it is sure that the test is
> consistently failing with 4.7.0rc0 and consistently OK with 4.6.1, on
> JDK8/Linux Fedora 26.
>
>
> If anyone wants to play with this error just checkout this branch from my
> GitHub fork of HerdDB and run this test
>
> git clone https://github.com/eolivelli/herddb
> git checkout fix/test-book keeper-470-rc
> mvn clean install -DskipTests
> mvn test -pl herddb-core -Dtest=BookkeeperFailuresTest
>


Self resolved. This is due to the change of default LedgerManagerFactory
from FlatLedgerManagerFactory to HierarchicalLedgerManagerFactory.
During tests there was no explicit setting so with 4.6.1 the test was using
FlatLedgerManagerFactory, now it is using HierarchicalLedgerManagerFactory.
The (non-) problem is that FlatLedgerManagerFactory returns as first
ledgerId a value of 1, and HierarchicalLedgerManagerFactory returns 0.

The test was checking that ledgerId IS always greater than 0.

This is not an issue, we have documented this change and this change does
not affect production sites because LedgerManagerFactory is set at cluster
setup, at the very first creation of the layout on ZK.

So this is not a blocker, it is only a "documented" change.

Enrico



>
>
> Stay tuned.
>
> Enrico
>
>
>
>
>
>
> 2018-04-11 13:37 GMT+02:00 Enrico Olivelli <eolivelli@xxxxxxxxx>:
>
>> Sorry,
>> -1
>>
>> "localbookie" is not working
>>
>> Steps to reproduce:
>> - download https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper
>> -4.7.0-rc0/bookkeeper-all-4.7.0-bin.tar.gz
>> - untar
>> - cd bookkeeper-all-4.7.0
>> - bin/bookkeeper localbookie 1
>>
>>
>> Enrico
>>
>>
>> 2018-04-11 13:35:56,700 - ERROR - [main:LocalBookKeeper@457] - Exiting
>> LocalBookKeeper because of exception in main method
>> java.lang.IllegalArgumentException: Illegal character in scheme name at
>> index 0: "zk+hierarchical://localhost:2181/ledgers"
>>     at java.net.URI.create(URI.java:852)
>>     at org.apache.bookkeeper.bookie.Bookie.instantiateMetadataDrive
>> r(Bookie.java:934)
>>     at org.apache.bookkeeper.bookie.Bookie.<init>(Bookie.java:626)
>>     at org.apache.bookkeeper.proto.BookieServer.newBookie(BookieSer
>> ver.java:115)
>>     at org.apache.bookkeeper.proto.BookieServer.<init>(BookieServer
>> .java:96)
>>     at org.apache.bookkeeper.proto.BookieServer.<init>(BookieServer
>> .java:77)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.runBookies(LocalB
>> ookKeeper.java:262)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.runBookies(LocalB
>> ookKeeper.java:158)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.startLocalBookies
>> Internal(LocalBookKeeper.java:359)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.main(LocalBookKee
>> per.java:454)
>> Caused by: java.net.URISyntaxException: Illegal character in scheme name
>> at index 0: "zk+hierarchical://localhost:2181/ledgers"
>>     at java.net.URI$Parser.fail(URI.java:2848)
>>     at java.net.URI$Parser.checkChars(URI.java:3021)
>>     at java.net.URI$Parser.checkChar(URI.java:3031)
>>     at java.net.URI$Parser.parse(URI.java:3047)
>>     at java.net.URI.<init>(URI.java:588)
>>     at java.net.URI.create(URI.java:850)
>>     ... 9 more
>> java.lang.IllegalArgumentException: Illegal character in scheme name at
>> index 0: "zk+hierarchical://localhost:2181/ledgers"
>>     at java.net.URI.create(URI.java:852)
>>     at org.apache.bookkeeper.bookie.Bookie.instantiateMetadataDrive
>> r(Bookie.java:934)
>>     at org.apache.bookkeeper.bookie.Bookie.<init>(Bookie.java:626)
>>     at org.apache.bookkeeper.proto.BookieServer.newBookie(BookieSer
>> ver.java:115)
>>     at org.apache.bookkeeper.proto.BookieServer.<init>(BookieServer
>> .java:96)
>>     at org.apache.bookkeeper.proto.BookieServer.<init>(BookieServer
>> .java:77)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.runBookies(LocalB
>> ookKeeper.java:262)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.runBookies(LocalB
>> ookKeeper.java:158)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.startLocalBookies
>> Internal(LocalBookKeeper.java:359)
>>     at org.apache.bookkeeper.util.LocalBookKeeper.main(LocalBookKee
>> per.java:454)
>> Caused by: java.net.URISyntaxException: Illegal character in scheme name
>> at index 0: "zk+hierarchical://localhost:2181/ledgers"
>>     at java.net.URI$Parser.fail(URI.java:2848)
>>     at java.net.URI$Parser.checkChars(URI.java:3021)
>>     at java.net.URI$Parser.checkChar(URI.java:3031)
>>     at java.net.URI$Parser.parse(URI.java:3047)
>>     at java.net.URI.<init>(URI.java:588)
>>     at java.net.URI.create(URI.java:850)
>>     ... 9 more
>> [enrico.olivelli@dna101pc231 bookkeeper-all-4.7.0]$ bin/bookkeeper
>> localbookie 10
>>
>> 2018-04-11 12:05 GMT+02:00 Sijie Guo <guosijie@xxxxxxxxx>:
>>
>>> Hi everyone,
>>>
>>> Please review and vote on the release candidate #0 for the version 4.7.0,
>>> as follows:
>>> [ ] +1, Approve the release
>>> [ ] -1, Do not approve the release (please provide specific comments)
>>>
>>> The complete staging area is available for your review, which includes:
>>> * Release notes [1]
>>> * The official Apache source and binary distributions to be deployed to
>>> dist.apache.org [2]
>>> * All artifacts to be deployed to the Maven Central Repository [3]
>>> * Source code tag "release-4.7.0" [4] with git sha
>>> e82e8807870c6fa8eb52cbb4b52dfbfdd70dc354
>>>
>>> BookKeeper's KEYS file contains PGP keys we used to sign this release:
>>> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
>>>
>>> Please download these packages and review this release candidate:
>>>
>>> - Review release notes
>>> - Download the source package (verify shasum, and asc) and follow the
>>> instructions to build and run the bookkeeper service.
>>> - Download the binary package (verify shasum, and asc) and follow the
>>> instructions to run the bookkeeper service.
>>> - Review maven repo, release tag, licenses, and any other things you
>>> think
>>> it is important to a release.
>>>
>>> NOTE: 4.7.0 release introduced `circe-checksum` module, which currently
>>> only ships a precompiled linux JNI lib along with the artifact.
>>>
>>> The vote will be open for at least 72 hours. It is adopted by majority
>>> approval, with at least 3 PMC affirmative votes.
>>>
>>> Thanks,
>>> Sijie Guo
>>>
>>> [1] https://github.com/apache/bookkeeper/pull/1330
>>> [2] https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper
>>> -4.7.0-rc0/
>>> [3]
>>> https://repository.apache.org/content/repositories/orgapache
>>> bookkeeper-1028/
>>> [4] https://github.com/apache/bookkeeper/tree/release-4.7.0
>>>
>>
>>
>