git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DISCUSS] Inconsistency in Handle based APIs - Specifically "close"


On Tue, Mar 20, 2018 at 12:50 AM, Ivan Kelly <ivank@xxxxxxxxxx> wrote:

> On Mon, Mar 19, 2018 at 6:37 PM, Sijie Guo <guosijie@xxxxxxxxx> wrote:
> > It is not a blocker for me.
> >
> > But if we want consistency, either applying pattern "asyncXYZ()" or
> > "xyzAsync()" for async operations works for me.
> xyzAsync is better than asyncXyz, as it will put the async and sync
> versions together in the javadoc.
>
> So, there's 3 options here.
>
> 1. Remove Closeable
> 2. Some kind of split of sealing and close
> 3. Create sync and async versions of all with Async suffix.
>
> I think 3 is the most palatable. If there's no objections I'll push a
> patch later today.
>

+1 on 3

>
> -Ivan
>