git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DISCUSS] Set `ENABLE_DIGEST_TYPE_AUTODETECTION` to true as default value


Good idea
I have already responded on the PR

Summary of my response:

   1. okay to make it the default
   2. may this change break existing tests, or at least change the meaning
   of what is tested ?
   3. we should add a test about this change, at least on the new API


Enrico



2018-03-13 8:41 GMT+01:00 Sijie Guo <guosijie@xxxxxxxxx>:

> Hi all,
>
> I am raising a discussion to set `ENABLE_DIGEST_TYPE_AUTODETECTION' to
> true
> to turn on this feature by default.  because `digest type` has been
> recorded in ledger metadata since 4.5, it is better for client to use the
> digest type recorded in ledger metadata.
>
> Here is a proposal of the change:
> https://github.com/apache/bookkeeper/pull/1252
>
> - Sijie
>