[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] I made a new tabbed Beam view in Jenkins

The _Cron variants of pre-commits are run post-commit, to make it easier to tell if the pre-commit is flaky or broken.

On Tue, Dec 18, 2018 at 1:40 PM Jason Kuster <jasonkuster@xxxxxxxxxx> wrote:
This looks great! (also it looks like some precommits snuck into the postcommit view)

On Tue, Dec 18, 2018 at 1:25 PM Alan Myrvold <amyrvold@xxxxxxxxxx> wrote:
It does look much better!

On Tue, Dec 18, 2018 at 1:10 PM Ahmet Altay <altay@xxxxxxxxxx> wrote:
I like this version, it looks cleaner than the current combined view.

On Tue, Dec 18, 2018 at 12:53 PM Scott Wegner <swegner@xxxxxxxxxx> wrote:
Very cool. I also didn't realize we had control over the Jenkins "views".

We currently lack a decent dashboard to monitor the build health across Beam jenkins jobs and triage failures; this is a step in the right direction.

I haven't played with Jenkins views before, but it appears they can be managed via the Job DSL similar to our job definitions [1]:

> The DSL execution engine exposes several methods to create Jenkins jobs, views, folders and config files. [..]

It would be cool to integrate this into our job config in such a way that we could automatically keep the views up-to-date as jobs are added or renamed.


On Tue, Dec 18, 2018 at 12:35 PM Anton Kedin <kedin@xxxxxxxxxx> wrote:
This is really helpful, didn't realize it was possible. Categories and contents look reasonable. I think something like this definitely should be the top-level Beam view.


On Tue, Dec 18, 2018 at 12:05 PM Kenneth Knowles <kenn@xxxxxxxxxx> wrote:
Hi all,

I made a new view to split Beam builds into tabs:

 - PostCommit tab includes PostCommit and "PreCommit_.*_Cron" because these are actually post-commit jobs; it is a feature not a bug.
 - PreCommit tab includes jobs that have no meaningful history because they are just against PRs, commits, phrase triggering
 - Inventory self-explanatory
 - PerformanceTests self-explanatory
 - All; I didn't want to keep making categories but just send this for feedback

WDYT about making this the top-level Beam view? (vs

After that, maybe we could clean the categories so they fit into the tabs more easily with fewer regexes (to make sure things don't get missed). I have read also that if you use / instead of _ as a separator in a name then Jenkins will display jobs as nested in folders automatically. Not sure it actually results in a better view; haven't tried it.



Jason Kuster
Apache Beam / Google Cloud Dataflow

See something? Say something. go/jasonkuster-feedback