git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Review Request 66974: ATLAS-2646 : Glossary: Allow to associate term to the term attributes.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66974/#review202524
-----------------------------------------------------------


Ship it!




Keval - Glossary UI updates look good. Thanks!

Please consider the following updates in a subsequent patch:
 - consider adding 'Related Terms' tab, to render all relationships in a table - one relationship per row. Like: one row each for seeAlso, synonyms, antonyms, preferredTerms, ..
 - consider adding a tab for each relationship (seeAlso/synonyms/antonyms/..), which will essentially replace current 'Properties' tab
 - popup to associate terms: should have the current term's glossary as selected
 - popup to associate terms: input for relationship attributes (description/expression/steward/source) appear at the bottom of the page, and easy to miss. Consider moving these to the top
 - 'Properties' tab: term relationship attribute values should be editable - similar to classification attributes. Currently only 'Delete' button is shown.

- Madhan Neethiraj


On May 5, 2018, 5:16 p.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66974/
> -----------------------------------------------------------
> 
> (Updated May 5, 2018, 5:16 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2646
>     https://issues.apache.org/jira/browse/ATLAS-2646
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Allow term association to the following attributes.
> 
> * seeAlso
> * synonyms
> * antonyms
> * preferredTerms
> * preferredToTerms
> * replacementTerms
> * replacedBy
> * translationTerms
> * translatedTerms
> * isA
> * classifies
> * validValues
> * validValuesFor
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/models/VGlossary.js 63eb9d270 
>   dashboardv2/public/js/modules/Helpers.js 7393a790d 
>   dashboardv2/public/js/templates/glossary/AssignTermLayoutView_tmpl.html 1590a2903 
>   dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 08fc72dd7 
>   dashboardv2/public/js/templates/glossary/TermRelationAttributeLayoutView_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/templates/glossary/TermRelationAttributeTable_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/utils/Enums.js ca8608fb1 
>   dashboardv2/public/js/views/glossary/AssignTermLayoutView.js 66353ad70 
>   dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 31d66a8b0 
>   dashboardv2/public/js/views/glossary/GlossaryLayoutView.js edbbe09a6 
>   dashboardv2/public/js/views/glossary/TermRelationAttributeLayoutView.js PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66974/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity test
> 
> 
> Thanks,
> 
> keval bhatt
> 
>