git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Review Request 66941: ATLAS-2643: Re-evaluate tag propagation when a relationship edge is deleted


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66941/#review202398
-----------------------------------------------------------


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java
Lines 886 (patched)
<https://reviews.apache.org/r/66941/#comment284211>

    rename:  relationshipGuid ==> guidRelationshipToExclude
    
    Also, please rename corresponding bind parameter name.


- Madhan Neethiraj


On May 3, 2018, 11:10 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66941/
> -----------------------------------------------------------
> 
> (Updated May 3, 2018, 11:10 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2643
>     https://issues.apache.org/jira/browse/ATLAS-2643
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> When a relationship edge is deleted, reevaluate all propagated classifications flowing through the edge.
> 
> 
> Diffs
> -----
> 
>   pom.xml 501ea61e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 86a6b812 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java cf6f72f4 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java d79d914e 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1.java edf1eed4 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java 83c6e07c 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlin3QueryProvider.java 8555f70f 
>   repository/src/main/java/org/apache/atlas/util/AtlasGremlinQueryProvider.java e2992f17 
> 
> 
> Diff: https://reviews.apache.org/r/66941/diff/1/
> 
> 
> Testing
> -------
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/345/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>