git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [CI] Code coverage reports


hey Antoine,

Looks like codecov is enabled now. I'm not sure when that happened,
maybe when we made the Gitbox transition? The last time I took up this
issue with ASF Infra was in 2016, I can't seem to find the ticket, but
here is one where they say the "permissions are too broad"

https://issues.apache.org/jira/browse/INFRA-11207?jql=project%20%3D%20INFRA%20AND%20text%20~%20codecov%20ORDER%20BY%20created%20DESC

Thanks for doing this! I am sure our code coverage has suffered as a
result of not having the reports. I wonder what it would take to get
C++ coverage that includes lines touched by Python unit test execution

- Wes

On Fri, May 11, 2018 at 4:01 AM, Antoine Pitrou <antoine@xxxxxxxxxx> wrote:
>
> Hi Wes,
>
> Le 11/05/2018 à 05:32, Wes McKinney a écrit :
>>
>> I also prefer codecov.io, but unfortunately Apache Infra does not
>> support it I believe due to some app hook permissions issue (there are
>> some similar problems preventing CircleCI from being made available to
>> Apache projects). I have asked before, you are welcome to open an
>> INFRA ticket to ask again.
> Can you elaborate on "Apache Infra does not support it"?  What does it
> mean for us exactly?
>
> Right now a typical PR gets coverage measured and posted as a comment by
> the codecov bot (*).  Do we expect some tighter integration with GitHub?
>
> (*) example: https://github.com/apache/arrow/pull/2026
>
> Regards
>
> Antoine.