git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[jira] [Commented] (ARIES-1805) Blueprint core dose not honor Java beans specification


    [ https://issues.apache.org/jira/browse/ARIES-1805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496703#comment-16496703 ] 

ASF GitHub Bot commented on ARIES-1805:
---------------------------------------

GitHub user valdar opened a pull request:

    https://github.com/apache/aries/pull/85

    Modified ReflectionUtilsTest#testDuplicateGetter to reflect ARIES-1805

    The test is not passing, is just as a reference for implementation.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/valdar/aries ARIES-1805

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/aries/pull/85.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #85
    
----
commit e2d31d45331c47b42c86668d732b0e3ed48a1394
Author: Andrea Tarocchi <atarocch@...>
Date:   2018-05-31T15:19:42Z

    Modified ReflectionUtilsTest#testDuplicateGetter to reflect ARIES-1805

----


> Blueprint core dose not honor Java beans specification
> ------------------------------------------------------
>
>                 Key: ARIES-1805
>                 URL: https://issues.apache.org/jira/browse/ARIES-1805
>             Project: Aries
>          Issue Type: Bug
>          Components: Blueprint
>    Affects Versions: blueprint-core-1.8.0
>            Reporter: Andrea Tarocchi
>            Priority: Major
>
> Aries blueprint core, to consider a property legit, checks that is and get access methods are not present at the same time: https://github.com/apache/aries/blob/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/utils/ReflectionUtils.java#L222-L255 specifically: https://github.com/apache/aries/blob/trunk/blueprint/blueprint-core/src/main/java/org/apache/aries/blueprint/utils/ReflectionUtils.java#L249
> looking at java bean specification: http://download.oracle.com/otn-pub/jcp/7224-javabeans-1.01-fr-spec-oth-JSpec/beans.101.pdf?AuthParam=1527758194_593d6e2c9336cf75e216a3333390c7b9
> it seems that both access methods ({{is}} and {{get}}) are allowed to be present at the same time, in that case, the {{is}} has to be used:
> bq. *8.3.2* Boolean properties In addition, for boolean properties, we allow a getter method to match the pattern: public boolean is<PropertyName>(); This “is<PropertyName>” method may be provided instead of a “get<PropertyName>” method, or it may be provided in addition to a “get<PropertyName>” method. In either case, if the “is<PropertyName>” method is present for a boolean property then we will use the “is<PropertyName>” method to read the property value.
> Should the Aries implementation b modified accordingly?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)