git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: jmod and jlink support


Hi Craig

On 2018-11-30, Craig Pell wrote:

>>> Has there been discussion or a bug filed regarding adding tasks to
>>> support jmod and jlink?  Now that there is no longer a separate JRE
>>> and the new method of distributing standalone Java applications
>>> requires jlink, this seems increasingly important.

>> There is a deprecated jlink task for an ancient tool which may cause a
>> bit of confusion.

> My task is simply named <link>.  And I’ve added a short note at the
> start of <jlink>’s documentation, referring readers to <link>.

Sounds good.

>>> I wasn’t sure whether the code is required to be Java 8 compatible.

>> If it is not, then the release manager will need to build Ant with
>> something more recent than Java 8. As long as this still allows to set
>> the javac -target to 8, this is probably fine.

>> Ant has included tasks that have been conditional on recent JDKs for a
>> long time. I.e. we've had tasks that required Java 5 to compile even
>> back when the base line was Java 1.3.

>> You can take a look at the build file for 1.8.4 to see how we handled it
>> back then: https://github.com/apache/ant/blob/rel/1.8.4/build.xml#L174
>> is the starting point to see how/where we dealt with those classes.

> I added a "needs.jdk9+" selector (and added use of it to the
> conditional-patterns aggregate selector).  But bootstrap.sh ignores it
> and attempts to build all files in the ‘taskdefs’ package, so I never
> get a chance to see the selector in action.

You will see it when you build with Java8.

> Should I modify bootstrap.sh and bootstrap.bat to exclude the newer
> tasks if using a Java version less than 9?

This is what the selector is supposed to do. No need to touch any of the
scripts. One thing that I should have mentioned, the classes that
require Java 9 must not live inside the taskdefs package directly
(rather in org.apache.tools.ant.taskdefs.optional or similar) so that
bootstrap won't trip over it.

> Or am I misunderstanding the goal?  Are you suggesting that future
> versions of Ant should just be built with Java 9 (or later)?

No.

The baseline for Ant 1.10.x is supposed to be Java 8 and it must be
possible to build Ant there. But when we create binary releases we try
to build all optional parts as well. Which in this case means the
release manager will need to build using Java 9.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx