git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [3/3] ant git commit: Use try-with-resources


On 2018-11-18, Stefan Bodewig wrote:

> In Manifest

>>      /** Encoding to be used for JAR files. */
>> -    public static final String JAR_ENCODING = "UTF-8";
>>>    public static final Charset JAR_ENCODING = StandardCharsets.UTF_8;

> chnages the type of a public constant which is not backwards
> compatible. Besides, this really is not related to try-with-resources at
> all.

> Please revert this part.

Just saw you've already taken care of this part in your next commit.
Thank you.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx