git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [1/2] ant git commit: Simplify tests, use Charset


On 2018-11-11, <gintas@xxxxxxxxxx> wrote:

>+     * Construct a <code>ReaderInputStream</code>
>+     * for the specified <code>Reader</code>,
>+     * with the specified encoding.
>+     *
>+     * @param reader     non-null <code>Reader</code>.
>+     * @param charset    non-null <code>Charset</code> charset.
>+     */
>+    public ReaderInputStream(Reader reader, Charset charset) {

please add a @since marker.

>>        if (charset == null) {
>>            throw new IllegalArgumentException("encoding must not be null");

s/encoding/charset/

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx