git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Add magic names for tests, run more tests in Surefire


On 2018-10-28, Gintautas Grigelionis wrote:

> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig <bodewig@xxxxxxxxxx> wrote:

>> On 2018-10-28, Gintautas Grigelionis wrote:
>>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig <bodewig@xxxxxxxxxx> wrote:

>>>> I wonder whether it wouldn't be a good idea to create a separate class
>>>> for constants used during testing that lives in ant-testutil rather than
>>>> poluting the "magic names" of Ant.

>>> The problem is that should such class end up in ant-testutil, it makes
>> ant
>>> dependent on ant-util and that creates a dependency loop.

>> I'm talking about the "magic names" only used in tests. The four
>> properties with names that start with TEST_ should not be used inside
>> the rest of Ant, are they?

> I understand your point. TEST_ properties are only for tests. But, the
> tests themselves are a part of Ant core.

Are they? I really hope there are no test classes in ant.jar.

The constants can be moved to the tests jar of Ant core (where Ant core
likely means org.apache.ant:ant in Maven speak) and ant-testutil. All
Maven artifacts that are not org.apache.ant:ant can have a test scope
dependency on ant-testutil.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx