git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Add magic names for tests, run more tests in Surefire


On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig <bodewig@xxxxxxxxxx> wrote:

> On 2018-10-23, <gintas@xxxxxxxxxx> wrote:
>
> >
> http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java
>
> >+    /**
> >+     * Magic property that makes unit tests based on BuildFileTest
> >+     * or BuildFileRule ignore externally set basedir
> >+     * (typically by Surefire/Failsafe)
> >+     *
> >+     * Value: {@value}
> >+     * @since Ant 1.10.6
> >+     */
> >+    public static final String TEST_BASEDIR_IGNORE =
> "ant.test.basedir.ignore";
>
> I wonder whether it wouldn't be a good idea to create a separate class
> for constants used during testing that lives in ant-testutil rather than
> poluting the "magic names" of Ant.
>
> Stefan
>

The problem is that should such class end up in ant-testutil, it makes ant
dependent on ant-util and that creates a dependency loop.

Gintas