git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Remove redundancies


Pretty much every implementation of javac will automatically convert the
string concatenation code into StringBuilders. Decompile the byte code and
see for yourself.

On Tue, 21 Aug 2018 at 13:05, Stefan Bodewig <bodewig@xxxxxxxxxx> wrote:

>
> > diff --git a/src/main/org/apache/tools/ant/types/PatternSet.java
> b/src/main/org/apache/tools/ant/types/PatternSet.java
>
> > -                : new
> StringBuilder(baseString).append(";encoding->").append(encoding).toString();
> > +                : baseString + ";encoding->" + encoding;
>
> I don't understand what kind of redundancy have you been removing here.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx
>
>

-- 
Matt Sicker <boards@xxxxxxxxx>