git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] ant-ivy issue #73: Enable XML report parser to produce qualified extra attri...


Github user twogee commented on the issue:

    https://github.com/apache/ant-ivy/pull/73
  
    Sorry, my reasoning took the wrong turn, must be the heat ð??¦Yes, passing qualified attributes to XmlReportWriter is the way to go.
    
    I wonder what was the reason for using "extra-" hack? I assume it was conceived as a way to avoid dealing with with random namespaces in the XML report. If it makes sense to continue with that, a way to encode the namespace prefix must be figured out.
    
    That means one should look at the permitted characters in the [XML Specification](https://www.w3.org/TR/xml11/#NT-NameChar) and try to figure out a separator such that from a name constructed as  "extra<separator><namespace-prefix><separator>-<name>" a namespace prefix and a name could be extracted unambiguously.
    
    I propose using something like ".-_-." as a separator since it is unlikely to occur in any namespace prefixes for extra attributes describing Ivy artifacts (if somebody does that, it must be on purpose and thus an attempt to shoot oneself in the foot). Or should we rather deal with namespaces in XML reports?
    
    P.S. You're right about the Jira issue, please add it to the name of the PR (and eventually to the commit name). 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg02302.html on line 90
Call Stack
#TimeMemoryFunctionLocation
10.0007364632{main}( ).../msg02302.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg02302.html on line 90
Call Stack
#TimeMemoryFunctionLocation
10.0007364632{main}( ).../msg02302.html:0