git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] ant pull request #64: Add support for SAN extension in GenerateKey task


Github user jnsnkrllive commented on a diff in the pull request:

    https://github.com/apache/ant/pull/64#discussion_r202364682
  
    --- Diff: src/main/org/apache/tools/ant/taskdefs/GenerateKey.java ---
    @@ -413,6 +429,16 @@ public void execute() throws BuildException {
                 sb.append("\" ");
             }
     
    +        if (useExtension) {
    +            sb.append("-ext ");
    --- End diff --
    
    Hey @jaikiran, thanks for pointing that out. I agree, `useExtension` isn't necessary right now since only 1 extension is being supported. I'll fix this now.
    This mechanism or something similar/better can be introduced when we add support for another extension sometime in the future, when it's actually needed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx