git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FileUtils.normalize/isLeadingPath have bitten me


On 2018-07-02, Jaikiran Pai wrote:

> Sorry that I couldn't get to this earlier. My plan to spend more time
> on this during the weekend didn't work out.

It's been a weekend :-)

No worries.

> I just checked the commits related to this and it looks mostly
> correct. However, I am still not 100% sure we have covered it all with
> this new method that was introduced[1] and used in the unzip
> part. What I mean is, the API expectations are right. However the
> implementation _might_ need a bit of rethink since it still relies on
> path string comparison (checks like endsWith) instead of a getParent()
> check.

I mostly kept the string comparison for performance reasons, but maybe
that point is moot and performance should not be a concern
here. Rewriting it to use getParent is no problem at all.

> My suspicion is all theoretical at the moment and may not even be
> valid. I'm going to build the latest changes of Ant give it a try
> against a bunch of my theoretical use cases and see if my suspicions
> are really valid or not.

Thank you

      Stefan


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx