git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bz 62324


2018-06-09 13:56 GMT+02:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:

>
> On 09/06/18 5:22 PM, Gintautas Grigelionis wrote:
>
>>
>> Thanks for review, Jaikiran. You're correct, that is the proposed
>> solution,
>> adding a separator
>> (a newline followed by an exception name for clarity -- mind that
>> exception
>> is logged only in debug mode).
>>
> The exception class name would already be part of the stacktrace anyway,
> so IMO, that wouldn't be of much use. Plus the bugzilla
> description/comments state that the thing that's being logged twice is a
> message (is it the message from the exception class?). So even with this
> change, it will still end up being logged twice right?
>

Yes, but the double logging only occurs in debug mode AND when the message
is encapsulated in the exception which is added to the same event.

By the way, is this issue specific to the delete task?
>

I didn't investigate, because it is not easy to figure out if a task
creates an event which contains a message both per se and encapsulated in
an exception.

Gintas


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg02007.html on line 99
Call Stack
#TimeMemoryFunctionLocation
10.0009363512{main}( ).../msg02007.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg02007.html on line 99
Call Stack
#TimeMemoryFunctionLocation
10.0009363512{main}( ).../msg02007.html:0