git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GitHub] ant pull request #:


No problem. That change to WHATSNEW is fine, I don't mind.

-Jaikiran


On 13/05/18 1:03 PM, Gintautas Grigelionis wrote:
Thanks, great work! I hope you don't mind me taking the liberty to adjust
WHATSNEW.

Gintas

2018-05-13 6:01 GMT+02:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:

I did plan to addit yesterday, but my local tests did not trigger the
package-info constant pool entry for some reason. So I decided to not rush
it in and spend some time to get the test right, to make sure it works
fine. I'll add it in either tonight or tomorrow once I get to see what's
going on.

-Jaikiran



On 12/05/18 9:19 PM, twogee wrote:

Github user twogee commented on the pull request:

      https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b6
79705c2f2164426e7e6fb#commitcomment-28953469
         In src/main/org/apache/tools/ant/taskdefs/optional/depend/const
antpool/ConstantPoolEntry.java:
      In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java
on line 77:
      Please add 20 (package), too


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01935.html on line 129
Call Stack
#TimeMemoryFunctionLocation
10.0008364568{main}( ).../msg01935.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01935.html on line 129
Call Stack
#TimeMemoryFunctionLocation
10.0008364568{main}( ).../msg01935.html:0