git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Bz 62324


2018-06-09 13:31 GMT+02:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:

> For easy reference, the bug in discussion is this one
> https://bz.apache.org/bugzilla/show_bug.cgi?id=62324
>
>
> On 09/06/18 12:38 AM, Gintautas Grigelionis wrote:
>
>> Namely, a stack trace of the exception is logged (in debug mode only)
>> without any separator from the preceding message. While it seems that the
>> idea is that the stack trace should be presented as a continuation of the
>> message, IMO it would require a specially formatted message or, well, some
>> separator to be visually consistent.
>>
>> So the question is whether there is better solution than the one currently
>> proposed?
>>
> I saw a commit that was made linking to this bug
> https://github.com/apache/ant/commit/69a3f1c1577ef0cf43d2a93
> 4a109cb0843c5b754. Is that the proposed solution?
>
> I haven't investigated the issue myself, but I can't relate that commit as
> a solution to what's being discussed in that bug. If I understand it
> correctly, the commit seems to be now using the exception class' simple
> name (which by the way can be obtained by getClass().getSimpleName()
> instead of substring substitutions) and printing a newline and the
> exception class simple name and then follows it with the complete
> stacktrace. Earlier, before this commit, it used to print just the
> stacktrace. I don't see how this change would solve what's being discussed
> in that bugzilla.
>
> If this isn't the proposed solution, is there some other place I can read
> up on what's being proposed?
>
>
> -Jaikiran
>

Thanks for review, Jaikiran. You're correct, that is the proposed solution,
adding a separator
(a newline followed by an exception name for clarity -- mind that exception
is logged only in debug mode).

Gintas