git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GitHub] ant pull request #:


I did plan to addit yesterday, but my local tests did not trigger the package-info constant pool entry for some reason. So I decided to not rush it in and spend some time to get the test right, to make sure it works fine. I'll add it in either tonight or tomorrow once I get to see what's going on.

-Jaikiran


On 12/05/18 9:19 PM, twogee wrote:
Github user twogee commented on the pull request:

     https://github.com/apache/ant/commit/d0f9c2e121e2b3a18b679705c2f2164426e7e6fb#commitcomment-28953469
In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java:
     In src/main/org/apache/tools/ant/taskdefs/optional/depend/constantpool/ConstantPoolEntry.java on line 77:
     Please add 20 (package), too


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx