git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [2/2] ant git commit: Bz 22370: followlinks attribute


Hi Gintas

you should probably check and document how the new followlinks attribute
interacts with fileset's followsymlinks attribute.

Please add something to WHATSNEW.

Some additional notes inline.

On 2018-05-23, <gintas@xxxxxxxxxx> wrote:

> http://git-wip-us.apache.org/repos/asf/ant/blob/35a84fea/manual/Types/selectors.html
> ----------------------------------------------------------------------
> diff --git a/manual/Types/selectors.html b/manual/Types/selectors.html
> index 955a1b2..e3289af 100644
> --- a/manual/Types/selectors.html
> +++ b/manual/Types/selectors.html
> @@ -925,6 +925,11 @@
>          <td>Username of the expected owner</td>
>          <td>Yes</td>
>        </tr>
> +        <tr>
> +          <td>followlinks</td>
> +          <td>Must the selector follow symbolic links?</td>
> +          <td>No; defaults to <q>false</q> (was <q>true</q> before Ant 1.10.4)</td>
> +        </tr>
>      </table>

Why change the default?

> http://git-wip-us.apache.org/repos/asf/ant/blob/35a84fea/src/main/org/apache/tools/ant/types/selectors/OwnedBySelector.java

> +    /**
> +     * Sets the "follow links" flag.
> +     * @param followLinks the user name
> +     */
> +    public void setFollowLinks(String followLinks) {
> +        this.followLinks = PropertyHelper.toBoolean(followLinks);
> +    }

public void setFollowLinks(boolean followLinks) {
    this.followLinks = followLinks;
}

does the same and looks clearer to me. Same for the other attribute
setters.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx