[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Inline buildfile names, make search easier

On 30/04/18 3:52 PM, Gintautas Grigelionis wrote:
2018-04-30 9:55 GMT+00:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:

On 2018-04-30, Gintautas Grigelionis wrote:

My apologies for offending anyone; just one last silly question: why
uniformity is not a requirement?
Who's uniformity do you pick? There are so many choices that only depend
on taste.

assertEquals(x, y) vs assertThat(y, equalTo(x)) amd many many small
nuances that we all don't need to agree on, as long as we understand
what the code means and does and we accept to not change code just
because it doesn't conform to our own choices.

assertThat(object, matcher) is easier to parameterize, see MakeUrlTest.
And regarding parameterization, I have found at least three cases of
copy-paste errors
where two supposedly different test cases were, in fact, identical.

The assertEquals vs assertThat was an example of different ways a certain thing can be implemented. I hope you do realize that what we are discussing in this thread (and others) is much more broader than finding copy/paste errors due to usage of one API over other.


To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx

( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01894.html on line 108
Call Stack
10.0009358376{main}( ).../msg01894.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01894.html on line 108
Call Stack
10.0009358376{main}( ).../msg01894.html:0