[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Inline buildfile names, make search easier

2018-04-30 9:55 GMT+00:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:

> On 2018-04-30, Gintautas Grigelionis wrote:
> > My apologies for offending anyone; just one last silly question: why
> > uniformity is not a requirement?
> Who's uniformity do you pick? There are so many choices that only depend
> on taste.
> assertEquals(x, y) vs assertThat(y, equalTo(x)) amd many many small
> nuances that we all don't need to agree on, as long as we understand
> what the code means and does and we accept to not change code just
> because it doesn't conform to our own choices.

assertThat(object, matcher) is easier to parameterize, see MakeUrlTest.
And regarding parameterization, I have found at least three cases of
copy-paste errors
where two supposedly different test cases were, in fact, identical.