git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dependeset-test failures


On 2018-05-20, Gintautas Grigelionis wrote:

> 2018-05-20 19:52 GMT+02:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:

>>> Hi all

>>> while running all tests locally I saw dependeset-test is failing, they
>>> are also failing on Jenkins.

>> Found it

>> https://github.com/apache/ant/commit/11422630936848e82c7b13a
>> b3fa68a3003e10195#diff-d84918760549fe4c0e195ba6cbfef4d3R268

>> this must be max() - the order of the original compare may have been
>> unexpected, I dont know. I've fixed it by now.

>> May I use this as an additional hint that performing bulk changes that
>> nobody really reviews is a bad idea. In addition the test must have
>> failed everywhere where it was run.

> Sorry, my bad, no failures occurred locally,

No problem with the bug. What concerns me is that you say there have
been no failures locally. This means something must be wrong with the
way you run tests. Please figure out where the problem.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx