git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] ant pull request #:


Github user bodewig commented on the pull request:

    https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28590563
  
    In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
    In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java on line 117:
    Assuming `executeTarget` does not throw an exception, then the old test would pass while the new one won't.
    
    I totally agree the test looks strange and it is very likely the original should have actually asserted an exception has been thrown. At least the asserted log looks as if the test was expecting a failure.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx