git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] ant pull request #:


Github user twogee commented on the pull request:

    https://github.com/apache/ant/commit/81c3e6e3ddf5b1ef4e66018f1047e1b2ae8b3173#commitcomment-28589786
  
    In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java:
    In src/tests/junit/org/apache/tools/ant/taskdefs/optional/image/ImageTest.java on line 117:
    The original code catches RuntimeException and examines it, just what the ExpectedException is supposed to do. How on Earth it was supposed to execute assertContains in the same try is beyond me. It looks like a reasonable post-mortem, though. And, I actually ran the test ;-)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx