git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Yet more isEmpty()


On 2018-04-15, <gintas@xxxxxxxxxx> wrote:

> @@ -275,10 +270,7 @@ public class DefaultLogger implements BuildLogger {
>                      new BufferedReader(new StringReader(event.getMessage()))) {

>                      message.append(r.lines().map(line -> prefix + line)
> -                        .collect(Collectors.joining(StringUtils.LINE_SEP)));
> -                    if (message.length() == 0) {
> -                        message.append(prefix);
> -                    }
> +                        .collect(Collectors.joining(System.lineSeparator(), prefix, "")));
>                  } catch (IOException e) {
>                      // shouldn't be possible
>                      message.append(label).append(event.getMessage());

I think this puts the last "prefix" in the wrong position, In the
original code it was appended after the message, the new joining call
puts it before the joined message. The second and third arg of joining
need to be swapped IMHO.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01830.html on line 95
Call Stack
#TimeMemoryFunctionLocation
10.0005363416{main}( ).../msg01830.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01830.html on line 95
Call Stack
#TimeMemoryFunctionLocation
10.0005363416{main}( ).../msg01830.html:0