git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


On 2018-04-15, Gintautas Grigelionis wrote:

> Could you please explain what alternative approach does the "root"
> property support

It has been added with
https://github.com/apache/ant/commit/71333195c9d57d80d1a44cd8362a641c62d5e214
and the commit message states the main use case "running tests from
an arbitrary directory". I don't recall the details, you may want to
look at the mailing list archive of December 2004.

My main point is this is something that has been working for more than
thriteen years and I don't want to break it for people who rely on it
just because it makes running the tests from an IDE slightly
inconvenient (by having to remember something).

> _and_ add assumptions checks, since it causes nasty NPEs when not set?

IIRC the fallback would be to use the current working directory instead
of the "root" property if the former is not set. We can easily deal with
this by using

System.getProperty("root", System.getProperty("user.dir"))

instead, right?

> By the looks of it, JUnit 5 runner tests need an assumption check, too.

Not sure why, but I may again be missing something.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01829.html on line 105
Call Stack
#TimeMemoryFunctionLocation
10.0008364632{main}( ).../msg01829.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01829.html on line 105
Call Stack
#TimeMemoryFunctionLocation
10.0008364632{main}( ).../msg01829.html:0