git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Inline buildfile names, make search easier



On 30/04/18 12:52 PM, Gintautas Grigelionis wrote:
My apologies for offending anyone; just one last silly question: why
uniformity is not a requirement?
I think it has already been explained in the other thread why it's not a necessity for a project as large and as old as this one, especially when the changes aren't solving anything. Plus, I believe you even agreed to it, when this was explained in that other thread.

Either way, this isn't about uniformity. Take a look at this commit for example (and it's just one of the many). It was done, as you admit, because you wanted to find a particular piece of text when you run "grep configureProject". There's no level of uniformity that can solve such random requirements, unless of course the code is auto-generated to fit in these requirements.

I believe that even one language that espoused TMTOWDI has moved to
TIMTOWTDIBSCINABTE?
Sorry, I really don't know what that means or how that relates to what we are discussing.

-Jaikiran


Gintas

2018-04-30 5:56 GMT+00:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:

On 30/04/18 11:12 AM, Gintautas Grigelionis wrote:

Names of buildfiles used in tests can be found by "grep configureProject"?

Why is that even a requirement?

I think I am just repeating myself again and again in different mails.
Changes like these are random personal preferences. The fact that these are
being done even after the mail discussions we recently had, indicates that
the request to not do such changes have been ignored. This is going down
the route of a being some kind of a personal individual hobby project. So
I'm just going to stop bothering looking into these commits anymore and
just stay away from them and stop sending this frustrated and rude sounding
mails.

-Jaikiran

The point is that these names are used exactly once, and need not to be put
in a field which is named inconsistently.
Deviations from this rule of thumb indicate that tests are parameterized
in
a manner where each test has its own buildfile.

Gintas

2018-04-30 4:43 GMT+00:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:

What purpose is this change serving?
-Jaikiran


On 30/04/18 10:08 AM, gintas@xxxxxxxxxx wrote:

Repository: ant
Updated Branches:
     refs/heads/master 0add85310 -> f3dfb7779


Inline buildfile names, make search easier

Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/f3dfb777
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/f3dfb777
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/f3dfb777


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx