git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


2018-04-12 15:18 GMT+00:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:

> On 2018-04-12, Gintautas Grigelionis wrote:
>
> > 2018-04-12 14:39 GMT+00:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:
>
> >> On 2018-04-11, Gintautas Grigelionis wrote:
>
> >>> XMLCatalogTest is an example of unit tests complicated by root
> property.
>
> >> Actually, the test even passes if you remove the line using the property
> >> as long as your current working directory is Ant's basedir :-)
>
> > What is the reason of having and/or keeping the property, anyway?
>
> Running the test when your current working directory is not the root of
> the Ant source tree. I don't know who does so, but it has been something
> somebody needed some time ago (and took the time to make it
> possible). Right now I don't see any reason to stop supporting that.
>

I'd say it's the other way around: unless I'm mistaken, I have to remember
to set the property in the IDEs that I use
if I want to use a test case for debugging. So IMHO it's an unnecessary
complication for no good reason.

Gintas


( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01814.html on line 96
Call Stack
#TimeMemoryFunctionLocation
10.0006363608{main}( ).../msg01814.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01814.html on line 96
Call Stack
#TimeMemoryFunctionLocation
10.0006363608{main}( ).../msg01814.html:0