git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


On 2018-04-11, Gintautas Grigelionis wrote:

> 2018-04-11 6:25 GMT+00:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:´

>> On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:

>>> I wrote earlier that I was about to review the unit tests.
>>> I was particularly unhappy about the root-property hack for an ancient
>>> deficiency in Surefire.

>> I checked some of the mail discussions, but couldn't find any relevant
>> details about this. Can you explain what the root-property hack is? I also
>> don't understand how Surefire is related to our tests, which are run using
>> the junit and ant-unit framework. If I missed some previous discussion,
>> please pointme to it and I'll read up on that.


> It's quite unobtrusive so far, see

> https://github.com/apache/ant/commit/7a30a2b577ef60c6f05ccd9379326439f8c88fed
> https://github.com/apache/ant/commit/4a8ef26e69a586684685ec1ca072fbbccc7c00b0

I don't think the root property is related to that at all. In fact it
predates the poms as far as I remember.

> XMLCatalogTest is an example of unit tests complicated by root property.

Actually, the test even passes if you remove the line using the property
as long as your current working directory is Ant's basedir :-)

https://github.com/apache/ant/commit/71333195c9d57d80d1a44cd8362a641c62d5e214

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01810.html on line 107
Call Stack
#TimeMemoryFunctionLocation
10.0006364632{main}( ).../msg01810.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01810.html on line 107
Call Stack
#TimeMemoryFunctionLocation
10.0006364632{main}( ).../msg01810.html:0