git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ant git commit: Use isEmpty() in tasks


On 2018-04-06, <gintas@xxxxxxxxxx> wrote:

> http://git-wip-us.apache.org/repos/asf/ant/blob/73bda1fb/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> ----------------------------------------------------------------------
> diff --git a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java b/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> index 3ac33f5..7beac61 100644
> --- a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
>>>> b/src/main/org/apache/tools/ant/taskdefs/BindTargets.java
> @@ -65,7 +65,7 @@ public class BindTargets extends Task {
>          }

>          if (getOwningTarget() == null
> -                || !"".equals(getOwningTarget().getName())) {
> +                || getOwningTarget().getName().isEmpty()) {
>              throw new BuildException("bindtargets only allowed as a top-level task");
>          }

You've reverse the logic by accident.

This broke running the tests locally as well as in Jenkins, I've fixed
it now.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01773.html on line 97
Call Stack
#TimeMemoryFunctionLocation
10.0006363416{main}( ).../msg01773.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01773.html on line 97
Call Stack
#TimeMemoryFunctionLocation
10.0006363416{main}( ).../msg01773.html:0