git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


2018-04-14 16:23 GMT+00:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:

> On 2018-04-13, Gintautas Grigelionis wrote:
>
> > 2018-04-13 5:33 GMT+00:00 Stefan Bodewig <bodewig@xxxxxxxxxx>:
>
> >> Ant test cases are not designed to be run from an IDE, this has never
> >> been a goal. I'm surprised this system property is the only thing you
> >> need to remember :-)
>
> >  Well, I decided to give it a spin :-) I find it useful to run
> > debugger on test cases from IDE.
>
> I'm glad it works for you.
>
> Please don't break different approaches of doing things just to make the
> IDE use case easier, though. In particular please don't remove the root
> system property and please run all tests via the build file before
> pushing changes.
>

I do run tests, but my environment get messy sometimes, too.
I keep an eye on Jenkins, but I am not always in a position to fix things
immediately,
and I'm sorry about that.

Could you please explain what alternative approach does the "root" property
support
_and_ add assumptions checks, since it causes nasty NPEs when not set?
I'd rather be adding assumptions checks for "ant.home" property.
By the looks of it, JUnit 5 runner tests need an assumption check, too.

Thanks,
Gintas