git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GitHub] ant pull request #:


Github user bodewig commented on the pull request:

    https://github.com/apache/ant/commit/1c80d507f496dde98869890e671edf635bef8dec#commitcomment-28426843
  
    In src/main/org/apache/tools/ant/taskdefs/Sync.java:
    In src/main/org/apache/tools/ant/taskdefs/Sync.java on line 242:
    I think here and in the next hunk the classical loop was easier to read (in particular given the comment above the loop :-) than the foreach version - and the `Arrays.sort` may become expensive when the arrays are big.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx




( ! ) Warning: include(msgfooter.php): failed to open stream: No such file or directory in /var/www/git/apache-ant-development/msg01752.html on line 84
Call Stack
#TimeMemoryFunctionLocation
10.0006362888{main}( ).../msg01752.html:0

( ! ) Warning: include(): Failed opening 'msgfooter.php' for inclusion (include_path='.:/var/www/git') in /var/www/git/apache-ant-development/msg01752.html on line 84
Call Stack
#TimeMemoryFunctionLocation
10.0006362888{main}( ).../msg01752.html:0