git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


2018-04-11 6:25 GMT+00:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:´

> On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:
>
>> I wrote earlier that I was about to review the unit tests.
>> I was particularly unhappy about the root-property hack for an ancient
>> deficiency in Surefire.
>>
> I checked some of the mail discussions, but couldn't find any relevant
> details about this. Can you explain what the root-property hack is? I also
> don't understand how Surefire is related to our tests, which are run using
> the junit and ant-unit framework. If I missed some previous discussion,
> please pointme to it and I'll read up on that.


It's quite unobtrusive so far, see

https://github.com/apache/ant/commit/7a30a2b577ef60c6f05ccd9379326439f8c88fed
https://github.com/apache/ant/commit/4a8ef26e69a586684685ec1ca072fbbccc7c00b0

XMLCatalogTest is an example of unit tests complicated by root property.

Gintas