git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig <bodewig@xxxxxxxxxx> wrote:

> On 2018-04-07, Jaikiran Pai wrote:
>
> > I don't mean to appear authoritative but I feel that these mass,
> > never-ending changes to various projects under the Ant umbrella,
> > related to formatting, coding style, whitespaces, syntax changes and
> > such aren't really worth it.
>
> We've done some systematic changes in the past, usually when a certain
> pattern has lead to bugs and we wanted to ensure the pattern was
> eliminated systematically. There are some precendents around
> try-with-resources or the introduction of generics that were similar to
> Gintas' series of commits, but there've only been a few.
>
> We did have one big "cleanup" commit which has been the one that brought
> us the regressions in 1.10.2 and I deeply regret not taking the time
> reviewing the change back then.
>
>
I'm pretty sure I was the perpetrator of said commit and wanted to offer my
apologies.

Matt


>
> > Especially when a lot of those changes are merely, IMO, personal
> > preferences, to code that has been around for a long time now.
>
> > It's extremely hard to do any kind of review for such changes and IMO
> > they really don't add any value.
>
> Some of them certainly are personal preferences. I tend to agree that
> many of the latest changes are not really improving the code base.
>
> I'm about twenty commits behind on reviewing the changes.
>
> > I haven't been long around in the project, to have any kind of
> > authority on this matter, but having been involved in some other open
> > source projects, changes like these aren't really good nor are
> > typically considered required or accepted.
>
> You've got as much authority as anybody else of us to state you don't
> like the changes or as Gintas has stating they make to code base
> cleaner.
>
> Honestly, I would prefer to not make this type of change at the scale
> they have happened. Mostly because I feel I'm spending a lot of time
> reviewing changes that transform working code into equivalent working
> code. Not reviewig the changes is not an option.
>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx
>
>