git.net

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Mass changes to various projects under Ant umbrella - should we be doing it?


I sense a personal attack using broad, generalised accusations :-)
Could we please stop the inflammatory comments and be more to the point?

Yes, I did make a series of commits, but it's not endless. In fact, it is
to end pretty soon.
It is long merely because each commit is about a specific pattern
(sometimes applied to a specific part of code), so it is easier to follow.
Sometimes the commits are iterative, cleaning up or building upon previous
changes.
Java is a language with the syntax that changes and tries to accomodate new
patterns that make programming more efficient.
We should try to use these patterns everywhere because uniformity aids
comprehension. Old code is not a golden code, it's a rotten code.
If I slip up and propose something that's not up to snuff, I'll gladly
revert that -- and hopefully learn something in the process.
If it is of interest, I would gladly explain what kind of patterns I was
looking for.

Gintas

P.S.: A shoutout to Jan who encouraged to dig deeper on Ivy PR#31.

2018-04-07 5:41 GMT+00:00 Jaikiran Pai <jai.forums2013@xxxxxxxxx>:

> I don't mean to appear authoritative but I feel that these mass,
> never-ending changes to various projects under the Ant umbrella, related to
> formatting, coding style, whitespaces, syntax changes and such aren't
> really worth it. Especially when a lot of those changes are merely, IMO,
> personal preferences, to code that has been around for a long time now.
> It's extremely hard to do any kind of review for such changes and IMO they
> really don't add any value. I can understand if the changes are being done
> in specific section when a bug or feature involves that specific area of
> code, but a lot of these commits aren't of that nature.
>
> I haven't been long around in the project, to have any kind of authority
> on this matter, but having been involved in some other open source
> projects, changes like these aren't really good nor are typically
> considered required or accepted.
>
> Could we please reconsider whether or not we should be doing such changes?
>
> -Jaikiran
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@xxxxxxxxxxxxxx
> For additional commands, e-mail: dev-help@xxxxxxxxxxxxxx
>
>